Skip to content

fix(edit-table): oldValue 更新问题#62

Merged
levy9527 merged 1 commit intoFEMessage:devfrom
gd4Ark:fix/edit-table
Aug 10, 2020
Merged

fix(edit-table): oldValue 更新问题#62
levy9527 merged 1 commit intoFEMessage:devfrom
gd4Ark:fix/edit-table

Conversation

@gd4Ark
Copy link
Member

@gd4Ark gd4Ark commented Jun 4, 2020

fix #61

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Why

目前 oldValue 只会在 add 或者 delete 的时候才会更新,但是如果外部更新 vlaue,则不会更新 oldValue,导致 resetRowOptionsData 时找不到旧的 options

How

在 watch value 变更后 更新 oldValue

Preview

before

2020-06-04 10 50 10

after

2020-06-04 10 57 52

@auto-add-label auto-add-label bot added the bug Something isn't working label Jun 4, 2020
@netlify
Copy link

netlify bot commented Jun 4, 2020

Deploy preview for femessage-element ready!

Built with commit 4b9b96d

https://deploy-preview-62--femessage-element.netlify.app

@netlify
Copy link

netlify bot commented Jun 4, 2020

Deploy preview for femessage-element ready!

Built with commit 5538198

https://deploy-preview-62--femessage-element.netlify.app

@levy9527 levy9527 merged commit af8b9aa into FEMessage:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit-table oldValue 没更新

3 participants